Skip to content

N°4058 - Setup failed when added an encrypted field due to default value NULL non SODIUM compatible#754

Merged
odain-cbd merged 3 commits intodevelopfrom
feature/4058-decrypt-uninitializied
Oct 10, 2025
Merged

N°4058 - Setup failed when added an encrypted field due to default value NULL non SODIUM compatible#754
odain-cbd merged 3 commits intodevelopfrom
feature/4058-decrypt-uninitializied

Conversation

@odain-cbd
Copy link
Contributor

** Symptom**:
Itop setup fails when adding encrypted fields without any default value. in AfterDbCreation step, the application tries to decrypt field value with an invalid value (null/empty).

2021-06-02 17:56:20 | Error | An exception occurred: nonce size should be SODIUM_CRYPTO_SECRETBOX_NONCEBYTES bytes at line 330 in file /var/www/html/core/simplecrypt.class.inc.php | SetupLog

Fixing it in production could be really painfull and is seen as quite unfriendly...

@odain-cbd odain-cbd requested a review from rquetiez September 22, 2025 12:54
@odain-cbd odain-cbd self-assigned this Sep 22, 2025
@odain-cbd odain-cbd added bug Something isn't working internal Work made by Combodo labels Sep 22, 2025
@odain-cbd odain-cbd added this to the 3.2.2 milestone Sep 22, 2025
@odain-cbd odain-cbd requested a review from eespie October 8, 2025 06:20
@odain-cbd odain-cbd merged commit 318b792 into develop Oct 10, 2025
@odain-cbd odain-cbd deleted the feature/4058-decrypt-uninitializied branch October 10, 2025 12:25
Comment on lines -425 to +433
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove EOL's at end of the file!

@Molkobain
Copy link
Contributor

Molkobain commented Feb 4, 2026

@odain-cbd you set the milestone to 3.2.2 but has it was merged on the develop branch, it will be only on 3.3.0+ won't it? The support/3.2 branch was already created.

@Molkobain Molkobain modified the milestones: 3.2.2, 3.3.0, 3.2.3 Feb 4, 2026
@Molkobain
Copy link
Contributor

@odain-cbd replied in our internal ticket system. This is indeed not in iTop 3.2.2. It will be in iTop 3.2.3 (has to be cherry picked) and iTop 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants